Skip to content

fix: remove node-fetch, use built-in fetch#843

Merged
purplecabbage merged 4 commits intomasterfrom
fetch-update
Apr 30, 2025
Merged

fix: remove node-fetch, use built-in fetch#843
purplecabbage merged 4 commits intomasterfrom
fetch-update

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Jan 21, 2025

Motivation and Context

node-fetch@v2's dependencies use the built in punycode module, which is deprecated in node-22, and prints out a deprecation warning.

How Has This Been Tested?

-npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f08eaff) to head (8710b8f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #843   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3223      3222    -1     
  Branches       632       632           
=========================================
- Hits          3223      3222    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shazron shazron mentioned this pull request Jan 22, 2025
Closed
purplecabbage
purplecabbage approved these changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

MichaelGoberling
MichaelGoberling approved these changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome this is much needed

Do we need a min engine now for the built in fetch? I recall it became stable relatively recently

@purplecabbage purplecabbage merged commit 9c075a2 into master Apr 30, 2025
10 checks passed
@purplecabbage purplecabbage deleted the fetch-update branch April 30, 2025 23:51
purplecabbage added a commit that referenced this pull request Nov 10, 2025
@shazron @purplecabbage
fix: remove node-fetch, use built-in fetch (#843)
c3c3100 
* fix: remove node-fetch, use built-in fetch
---------

Co-authored-by: Jesse MacFadyen <purplecabbage@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purplecabbage purplecabbage purplecabbage approved these changes

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

@amulyakashyap09 amulyakashyap09 Awaiting requested review from amulyakashyap09

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shazron @purplecabbage @MichaelGoberling